Fix setup-uv cache dependency config in lint and test workflows#53
Fix setup-uv cache dependency config in lint and test workflows#53smortezah wants to merge 5 commits intotoon-format:mainfrom
Conversation
smortezah
changed the title
There was a problem hiding this comment.
Pull request overview
Adds cache-dependency-glob: pyproject.toml to setup-uv in both the lint and test workflows so the uv cache key is based on pyproject.toml instead of missing default files. Also adds a Copilot PR description template.
Changes:
- Add
cache-dependency-glob: pyproject.tomltosetup-uvinlint.ymlandtest.yml - Add
.copilot-pull-request-description-instructions.mdPR template
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/lint.yml |
Add cache dependency glob for uv |
.github/workflows/test.yml |
Add cache dependency glob for uv |
.copilot-pull-request-description-instructions.md |
New PR description template for Copilot |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
alesanfra
left a comment
alesanfra
left a comment
There was a problem hiding this comment.
It looks like pyproject.toml is already in the default dependency files according to the doc, am I missing something?
It should be, but for some reason the workflow doesn't run properly. Running the workflow locally, using https://github.com/nektos/act, with added lines make it work properly. To find out, we would need to approve the workflow to let it run. Then we'll see what happens. |
Summary
Configure
astral-sh/setup-uvcache invalidation explicitly in the lint workflow.Changes
enable-cache: truecache-dependency-glob: pyproject.tomlWhy
The workflow enables uv caching, but the repository does not appear to contain the default dependency files used by
setup-uvfor cache keys (uv.lockorrequirements*.txt). Pointing cache invalidation atpyproject.tomlavoids the warning and keeps caching enabled.